From dev-return-9006-archive-asf-public=cust-asf.ponee.io@curator.apache.org Fri Apr 6 05:26:34 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 52D1318063B for ; Fri, 6 Apr 2018 05:26:34 +0200 (CEST) Received: (qmail 50871 invoked by uid 500); 6 Apr 2018 03:26:32 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 50847 invoked by uid 99); 6 Apr 2018 03:26:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2018 03:26:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D854FF4E57; Fri, 6 Apr 2018 03:26:30 +0000 (UTC) From: Randgalt To: dev@curator.apache.org Reply-To: dev@curator.apache.org References: In-Reply-To: Subject: [GitHub] curator pull request #262: [CURATOR-460] Timed tolerance for connection susp... Content-Type: text/plain Message-Id: <20180406032630.D854FF4E57@git1-us-west.apache.org> Date: Fri, 6 Apr 2018 03:26:30 +0000 (UTC) Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/262#discussion_r179652781 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/state/ConnectionStateManager.java --- @@ -340,4 +338,12 @@ private void setCurrentConnectionState(ConnectionState newConnectionState) currentConnectionState = newConnectionState; startOfSuspendedEpoch = (currentConnectionState == ConnectionState.SUSPENDED) ? System.currentTimeMillis() : 0; } + + private synchronized int getUseSessionTimeoutMs() { --- End diff -- I think volatile is cleaner. I don't see any read/increments so it doesn't need to be AtomicLong either. ---