From dev-return-8748-archive-asf-public=cust-asf.ponee.io@curator.apache.org Mon Jan 8 16:49:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id B8B7618072F for ; Mon, 8 Jan 2018 16:49:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A4824160C2C; Mon, 8 Jan 2018 15:49:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F29EA160C40 for ; Mon, 8 Jan 2018 16:49:04 +0100 (CET) Received: (qmail 52112 invoked by uid 500); 8 Jan 2018 15:49:04 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 51930 invoked by uid 99); 8 Jan 2018 15:49:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 15:49:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 67672C3F4E for ; Mon, 8 Jan 2018 15:49:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id UJx7s_ana9Gb for ; Mon, 8 Jan 2018 15:49:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 036A75FAC9 for ; Mon, 8 Jan 2018 15:49:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 06F27E129D for ; Mon, 8 Jan 2018 15:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 683BD240FE for ; Mon, 8 Jan 2018 15:49:00 +0000 (UTC) Date: Mon, 8 Jan 2018 15:49:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@curator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CURATOR-447) TreeCache: Improve memory usage and concurrent update logic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CURATOR-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316508#comment-16316508 ] ASF GitHub Bot commented on CURATOR-447: ---------------------------------------- Github user njhill commented on the issue: https://github.com/apache/curator/pull/250 @dragonsinth @Randgalt any interest in these updates? FWIW I've had them running in production for some time. > TreeCache: Improve memory usage and concurrent update logic > ----------------------------------------------------------- > > Key: CURATOR-447 > URL: https://issues.apache.org/jira/browse/CURATOR-447 > Project: Apache Curator > Issue Type: Improvement > Components: Recipes > Affects Versions: 3.3.0, 2.12.0 > Reporter: Nick Hill > Priority: Minor > Labels: performance > > Jira https://issues.apache.org/jira/browse/CURATOR-374 reduced per-node memory usage in {{TreeCache}}. It can be improved further via removal of the {{nodeState}} field - its {{LIVE}} state corresponds exactly to the adjacent {{childData}} field being non-null, and a sentinel {{ChildData}} value can be used for the {{DEAD}} state. This simplification also reduces the room for bugs and state inconsistencies. > Other improvements included: > * A further simplification to have {{TreeNode}} extend {{AtomicReference}}, which obviates the need for an explicit {{childData}} field > * More robust cache update logic (in get-children and get-data event callbacks) > * Avoid overhead of incrementing/decrementing the {{outstandingOps}} atomic integer post-initialization -- This message was sent by Atlassian JIRA (v6.4.14#64029)