curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nivs <...@git.apache.org>
Subject [GitHub] curator pull request #226: SharedCount: fix removeListener
Date Wed, 05 Jul 2017 08:47:55 GMT
GitHub user nivs opened a pull request:

    https://github.com/apache/curator/pull/226

    SharedCount: fix removeListener

    `removeListener` only removed the listener from the SharedCount's `listeners` member,
which had no effect.
    This fix retrieves the `SharedValueListener` created for wrapping the `SharedCountListener`
and removes it from the SharedValue's listeners.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nivs/curator patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
    
----
commit b1ffac9145750e03c01c4ce6823f4a8536054a1e
Author: Niv Singer <niv@innerlogics.com>
Date:   2017-07-05T08:47:13Z

    SharedCount: fix removeListener
    
    `removeListener` only removed the listener from the SharedCount's `listeners` member,
which had no effect.
    This fix retrieves the `SharedValueListener` created for wrapping the `SharedCountListener`
and removes it from the SharedValue's listeners.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message