curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request #218: [CURATOR-407] Added ttl suppport to Create transa...
Date Wed, 03 May 2017 22:50:16 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/218#discussion_r114671266
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/api/transaction/TransactionCreateBuilder.java
---
    @@ -18,17 +18,17 @@
      */
     package org.apache.curator.framework.api.transaction;
     
    -import org.apache.curator.framework.api.ACLCreateModePathAndBytesable;
    -import org.apache.curator.framework.api.ACLPathAndBytesable;
    -import org.apache.curator.framework.api.Compressible;
    -import org.apache.curator.framework.api.CreateModable;
    -import org.apache.curator.framework.api.PathAndBytesable;
    -
    -public interface TransactionCreateBuilder<T> extends
    -    PathAndBytesable<T>,
    -    CreateModable<ACLPathAndBytesable<T>>,
    -    ACLPathAndBytesable<T>,
    -    ACLCreateModePathAndBytesable<T>,
    -    Compressible<ACLCreateModePathAndBytesable<T>>
    +public interface TransactionCreateBuilder<T> extends TransactionCreateBuilder2<T>
    --- End diff --
    
    What would `withTTL()` return? It could return `TransactionCreateBuilder<T>` but
then you'd be able to do:
    
    ```
    client.create().withTtl(x).withTtl(x).withTtl(x)...
    ```
    The rest of the DSLs avoid this type of thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message