curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request #218: [CURATOR-407] Added ttl suppport to Create transa...
Date Wed, 03 May 2017 22:46:56 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/218#discussion_r114670836
  
    --- Diff: curator-x-async/src/main/java/org/apache/curator/x/async/details/AsyncTransactionOpImpl.java
---
    @@ -77,6 +78,13 @@ public AsyncTransactionCreateBuilder create()
                 }
     
                 @Override
    +            public AsyncPathAndBytesable<CuratorOp> withTtl(long ttl)
    +            {
    +                this.ttl = ttl;
    +                return this;
    +            }
    +
    +            @Override
                 public AsyncPathAndBytesable<CuratorOp> withOptions(CreateMode createMode,
List<ACL> aclList, boolean compressed)
                 {
                     this.createMode = Objects.requireNonNull(createMode, "createMode cannot
be null");
    --- End diff --
    
    Yeah - that's true


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message