curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-370) Replace use of MoreExecutors.sameThreadExecutor
Date Fri, 06 Jan 2017 11:40:58 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804362#comment-15804362
] 

ASF GitHub Bot commented on CURATOR-370:
----------------------------------------

GitHub user thecoop opened a pull request:

    https://github.com/apache/curator/pull/188

    [CURATOR-370] - Update guava to 18, change use of sameThreadExecutor() to directExecutor()

    guava update is CURATOR-263

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thecoop/curator CURATOR-370

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
    
----
commit 54e4a577fae4ba7806d8eac754f94d7120b093d8
Author: Simon Cooper <simon.cooper@featurespace.co.uk>
Date:   2017-01-06T11:38:35Z

    Update guava to 18.0
    change uses of sameThreadExecutor() to directExecutor()

----


> Replace use of MoreExecutors.sameThreadExecutor
> -----------------------------------------------
>
>                 Key: CURATOR-370
>                 URL: https://issues.apache.org/jira/browse/CURATOR-370
>             Project: Apache Curator
>          Issue Type: Improvement
>    Affects Versions: 3.2.1, 2.11.1
>            Reporter: Simon Cooper
>            Assignee: Jordan Zimmerman
>              Labels: dependencies
>
> {{ListenerContainer}} has a reference to {{MoreExecutors.sameThreadExecutor}} in guava.
This method has been deprecated since guava version 18.0, and is being removed in version
21.0. This should be changed to use {{MoreExecutors.directExecutor}} instead.
> The use of this method means that all projects using Curator can't use a guava version
past 20.0, as the method no longer exists in 21, so I would say this is quite high priority
to fix, especially since 21.0 is the first Java 8 version of guava.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message