curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-369) Improve log format in EnsembleTracker.processConfigData()
Date Wed, 28 Dec 2016 17:42:58 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783348#comment-15783348
] 

ASF GitHub Bot commented on CURATOR-369:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/curator/pull/179


> Improve log format in EnsembleTracker.processConfigData()
> ---------------------------------------------------------
>
>                 Key: CURATOR-369
>                 URL: https://issues.apache.org/jira/browse/CURATOR-369
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 3.2.1
>            Reporter: Sylvain Wallez
>            Priority: Minor
>             Fix For: 3.2.2
>
>
> EnsembleFrameworkTracker has a [log statement|https://github.com/apache/curator/blob/CURATOR-3.0/curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java#L182]
that doesn't format its value correctly and is adding noise in log files.
> Sample output of this statement is as follows:
> {noformat}
> [2016-12-09 12:16:26,046][INFO ][org.apache.curator.framework.imps.EnsembleTracker][]
New config event received: [115, 101, 114, 118, 101, 114, 46, 49, 48, 61, 108, 111, 99, 97,
108, 104, 111, 115, 116, 58, 50, 56, 57, 56, 58, 51, 56, 57, 56, 58, 112, 97, 114, 116, 105,
99, 105, 112, 97, 110, 116, 59, 48, 46, 48, 46, 48, 46, 48, 58, 50, 49, 57, 49, 10, 118, 101,
114, 115, 105, 111, 110, 61, 49, 48, 48, 48, 48, 48, 48, 48, 48]
> {noformat}
> I'd like to provide a fix for this by logging the properties object once it's been parsed,
but I'm confused about what branch to patch against. This class exists in the CURATOR-3.0
branch, but not in master.
> Is creating a PR against the CURATOR-3.0 branch the way to go?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message