curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-361) NamespaceImpl.unfixForNamespace() removes leading slash if namespace is empty
Date Wed, 07 Dec 2016 02:01:59 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15727395#comment-15727395
] 

ASF GitHub Bot commented on CURATOR-361:
----------------------------------------

GitHub user cruhland opened a pull request:

    https://github.com/apache/curator/pull/176

    [CURATOR-361] Prevent removal of leading slash from path when empty namespace used

    In the test, I'm casting `CuratorFramework` to `CuratorFrameworkImpl` to get access to
`unfixForNamespace()`. It was the most direct way to write the test, but I'm open to suggestions
for cleaner code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cruhland/curator CURATOR-361

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #176
    
----
commit 82a8906ddb185e4d405056aeed8abc807f440440
Author: Charles Ruhland <charles@mesosphere.io>
Date:   2016-12-07T01:53:12Z

    [CURATOR-361] Prevent removal of leading slash from path when empty namespace used

----


> NamespaceImpl.unfixForNamespace() removes leading slash if namespace is empty
> -----------------------------------------------------------------------------
>
>                 Key: CURATOR-361
>                 URL: https://issues.apache.org/jira/browse/CURATOR-361
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: 2.11.1
>            Reporter: Charles Ruhland
>            Priority: Minor
>
> When using a {{CuratorFramework}} client with a namespace set explicitly to the empty
string via the builder, calls to {{unfixForNamespace()}} on its {{namespace}} field will result
in invalid paths that are missing their leading slash; e.g. {{/foo/bar}} becomes {{foo/bar}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message