curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator issue #165: [CURATOR-349] Expose extra metrics in TracerDriver
Date Mon, 26 Sep 2016 22:20:53 GMT
Github user cammckenzie commented on the issue:

    https://github.com/apache/curator/pull/165
  
    I've had a bit more of a look and I think that the changes are OK. As you mentioned, the
changes are only to internal classes. There is a loss of granularity (The TimeTrace was using
nanos while your new implementation is using millis), but I doubt that this is an issue in
practice. So, I'm happy with the changes.
    
    @Randgalt is away at the moment, but I think that he should review it when he returns.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message