curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtully <...@git.apache.org>
Subject [GitHub] curator pull request #161: CURATOR-344 - limit shared value watcher to valid...
Date Thu, 18 Aug 2016 18:39:46 GMT
GitHub user gtully opened a pull request:

    https://github.com/apache/curator/pull/161

    CURATOR-344 - limit shared value watcher to valid change events to av…

    …oid work on disconnect.
    
    Test that shows the difficulty with blocking the event thread. 
    When the framework is shared and one use case needs timely notification of suspend, a
use case that requires retry for some period gets in the way.
    
    In any event, on a disconnect, there may or may not be change, it does not make sense
to me that the listeners should be fired.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gtully/curator CURATOR-344

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit f89ddfafb45c4656ea34474f061ca902c7060116
Author: gtully <gary.tully@gmail.com>
Date:   2016-08-18T18:34:10Z

    CURATOR-344 - limit shared value watcher to valid change events to avoid work on disconnect

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message