curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator issue #161: CURATOR-344 - limit shared value watcher to valid change...
Date Sun, 28 Aug 2016 23:06:43 GMT
Github user cammckenzie commented on the issue:

    https://github.com/apache/curator/pull/161
  
    I'm not sure on the pattern for executors, probably just the whim of whoever implemented
the recipe I imagine.
    
    I think that you should be able to do this asynchronously without an executor though.
If you change the readValue() method to have an option of executing in the background then
it should fix the problem I think. When being called from the Watcher, you would make the
readValue getData() call in the background and update the shared value in the asynchronous
callback.
    
    That should fix the problem properly and not require the introduction of an executor.
I think that we should clean up the events which actually result in the readValue() being
called from the Watcher too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message