curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-327) NamespaceImpl does not report full error message to caller
Date Fri, 20 May 2016 21:15:13 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294218#comment-15294218
] 

ASF GitHub Bot commented on CURATOR-327:
----------------------------------------

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/150#discussion_r64108405
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/NamespaceImpl.java
---
    @@ -45,7 +45,7 @@
                 }
                 catch ( IllegalArgumentException e )
                 {
    -                throw new IllegalArgumentException("Invalid namespace: " + namespace);
    +                throw new IllegalArgumentException("Invalid namespace: " + namespace
+ ", " + e.getMessage());
    --- End diff --
    
    getMessage() can return `null`. Is that OK?


> NamespaceImpl does not report full error message to caller
> ----------------------------------------------------------
>
>                 Key: CURATOR-327
>                 URL: https://issues.apache.org/jira/browse/CURATOR-327
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 3.1.0, 2.10.0
>            Reporter: Raymond Mauge
>            Priority: Minor
>
> NamespaceImpl calls PathUtils.validatePath("/" + namespace) which returns a detailed
error message to NamespaceImpl. But NamespaceImpl completely ignores the message detail and
simply uses a generic message which is less than helpful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message