curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-327] - NamespaceImpl does not repor...
Date Fri, 20 May 2016 21:14:48 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/150#discussion_r64108405
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/NamespaceImpl.java
---
    @@ -45,7 +45,7 @@
                 }
                 catch ( IllegalArgumentException e )
                 {
    -                throw new IllegalArgumentException("Invalid namespace: " + namespace);
    +                throw new IllegalArgumentException("Invalid namespace: " + namespace
+ ", " + e.getMessage());
    --- End diff --
    
    getMessage() can return `null`. Is that OK?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message