curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-314] Listenable support for GroupMe...
Date Sun, 08 May 2016 19:01:36 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/141#discussion_r62436654
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/GroupMember.java
---
    @@ -75,6 +119,7 @@ public void start()
             try
             {
                 cache.start();
    +            cache.getListenable().addListener(childrenCacheListener);
    --- End diff --
    
    Why not add a proxy listener getListenable()? I need to think about this. Does this single
listener correctly proxy all behaviors from getListenable()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message