curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-317) Deprecation comment suggests code that is not equivalent
Date Thu, 21 Apr 2016 00:36:25 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251019#comment-15251019
] 

ASF GitHub Bot commented on CURATOR-317:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/curator/pull/144


> Deprecation comment suggests code that is not equivalent
> --------------------------------------------------------
>
>                 Key: CURATOR-317
>                 URL: https://issues.apache.org/jira/browse/CURATOR-317
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Jorge Montero
>            Priority: Trivial
>
> An old deprecation (from 2012) recommended replacing withProtectedEphemeralSequential()
with 
> withProtection().withMode(CreateMode.PERSISTENT_SEQUENTIAL), which does not do the same
thing! Anyone making that replacement will get persistent nodes instead of ephemeral modes,
which can cause all kinds of trouble (it definitely did for us!)
> It should be replaced with code that actually does the same thing as the old implementation:
				.withProtection().withMode(CreateMode.EPHEMERAL_SEQUENTIAL)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message