curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-317) Deprecation comment suggests code that is not equivalent
Date Wed, 20 Apr 2016 14:25:25 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249983#comment-15249983
] 

ASF GitHub Bot commented on CURATOR-317:
----------------------------------------

GitHub user hibikir opened a pull request:

    https://github.com/apache/curator/pull/144

    CURATOR-317: changed a deprecation comment to provide a better equivalent

    https://issues.apache.org/jira/browse/CURATOR-317
    
    Now anyone looking at the deprecated annotation will find code that is a drop in replacement.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hibikir/curator master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit 0ef5e454a7d72a65a3c14b47bf3c15f84ff9d4d6
Author: Jorge Montero <jxm@stripe.com>
Date:   2016-04-20T14:21:51Z

    changed a deprecation comment to provide a better equivalent

----


> Deprecation comment suggests code that is not equivalent
> --------------------------------------------------------
>
>                 Key: CURATOR-317
>                 URL: https://issues.apache.org/jira/browse/CURATOR-317
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Jorge Montero
>            Priority: Trivial
>
> An old deprecation (from 2012) recommended replacing withProtectedEphemeralSequential()
with 
> withProtection().withMode(CreateMode.PERSISTENT_SEQUENTIAL), which does not do the same
thing! Anyone making that replacement will get persistent nodes instead of ephemeral modes,
which can cause all kinds of trouble (it definitely did for us!)
> It should be replaced with code that actually does the same thing as the old implementation:
				.withProtection().withMode(CreateMode.EPHEMERAL_SEQUENTIAL)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message