curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-299] WatcherRemovalManager must be ...
Date Thu, 21 Apr 2016 04:47:58 GMT
Github user Randgalt commented on the pull request:

    https://github.com/apache/curator/pull/145#issuecomment-212742420
  
    I struggled with this PR. It ended up way more complicated than I wanted but it's difficult
to simplify. 
    
    > Wouldn't it have been cleaner to overload the constructor for OperationAndData with
a constructor that didn't take a Watching reference
    
    I don't generally like disjointed ctors. It's harder to use correctly. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message