curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-299] WatcherRemovalManager must be ...
Date Thu, 21 Apr 2016 03:55:42 GMT
Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/145#issuecomment-212727053
  
    Looks OK to me. A couple of thoughts though. Wouldn't it have been cleaner to overload
the constructor for OperationAndData with a constructor that didn't take a Watching reference?
There seems to have been a lot of changes just updating the constructor reference and passing
in a null Watching reference. Same for Backgrounding.checkError.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message