curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SamG1000 <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-219 Catch Exceptions, not Throwables
Date Sat, 02 Apr 2016 13:59:23 GMT
Github user SamG1000 commented on a diff in the pull request:

    https://github.com/apache/curator/pull/78#discussion_r58293712
  
    --- Diff: curator-client/src/main/java/org/apache/curator/ensemble/exhibitor/ExhibitorEnsembleProvider.java
---
    @@ -301,7 +301,7 @@ else if ( port != thePort )
                         values.putAll(decodeExhibitorList(encoded));
                         done = true;
                     }
    -                catch ( Throwable e )
    +                catch ( Exception e )
    --- End diff --
    
    You also need to \worry about ThreadDeath error:
    
    https://docs.oracle.com/javase/7/docs/api/java/lang/ThreadDeath.html
    ```
    An application should catch instances of this class only if it must clean up after being
terminated asynchronously. If ThreadDeath is caught by a method, it is important that it be
rethrown so that the thread actually dies.
    ```
    
    So ThreadDeath Error can be logged, but should never retry to avoid destabilizing JVM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message