Return-Path: 
 <dev-return-6000-apmail-curator-dev-archive=curator.apache.org@curator.apache.org>
X-Original-To: apmail-curator-dev-archive@minotaur.apache.org
Delivered-To: apmail-curator-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 65B2A1911D
	for <apmail-curator-dev-archive@minotaur.apache.org>;
 Mon, 21 Mar 2016 20:45:52 +0000 (UTC)
Received: (qmail 74579 invoked by uid 500); 21 Mar 2016 20:45:52 -0000
Delivered-To: apmail-curator-dev-archive@curator.apache.org
Received: (qmail 74532 invoked by uid 500); 21 Mar 2016 20:45:52 -0000
Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@curator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@curator.apache.org>
List-Post: <mailto:dev@curator.apache.org>
List-Id: <dev.curator.apache.org>
Reply-To: dev@curator.apache.org
Delivered-To: mailing list dev@curator.apache.org
Received: (qmail 74485 invoked by uid 99); 21 Mar 2016 20:45:51 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2016 20:45:51 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D5642DFA6C; Mon, 21 Mar 2016 20:45:51 +0000 (UTC)
From: madrob <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-137-curator@git.apache.org>
In-Reply-To: <git-pr-137-curator@git.apache.org>
Subject: [GitHub] curator pull request: Support EPHEMERAL_SEQUENTIAL nodes for
 Servi...
Content-Type: text/plain
Message-Id: <20160321204551.D5642DFA6C@git1-us-west.apache.org>
Date: Mon, 21 Mar 2016 20:45:51 +0000 (UTC)

Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/137#discussion_r56893744
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceDiscoveryImpl.java ---
    @@ -220,7 +220,18 @@ protected void internalRegisterService(ServiceInstance<T> service) throws Except
             {
                 try
                 {
    -                CreateMode mode = (service.getServiceType() == ServiceType.DYNAMIC) ? CreateMode.EPHEMERAL : CreateMode.PERSISTENT;
    +            	CreateMode mode;
    +            	switch (service.getServiceType()){
    --- End diff --
    
    nit: whitespace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---