curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Date Tue, 29 Mar 2016 02:07:49 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/140#discussion_r57663645
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentNode.java
---
    @@ -317,6 +317,7 @@ public String getActualPath()
         public void setData(byte[] data) throws Exception
         {
             data = Preconditions.checkNotNull(data, "data cannot be null");
    +        Preconditions.checkState(nodePath.get() != null, "initial create has not been
processed. Call waitForInitialCreate() to ensure.");
             this.data.set(Arrays.copyOf(data, data.length));
    --- End diff --
    
    The current behavior is undefined. I can't imagine anyone is dependent on an NPE. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message