curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <>
Subject [GitHub] curator pull request: [CURATOR-310] Race in PersistentNode startup
Date Tue, 29 Mar 2016 02:07:01 GMT
Github user cammckenzie commented on a diff in the pull request:
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/
    @@ -317,6 +317,7 @@ public String getActualPath()
         public void setData(byte[] data) throws Exception
             data = Preconditions.checkNotNull(data, "data cannot be null");
    +        Preconditions.checkState(nodePath.get() != null, "initial create has not been
processed. Call waitForInitialCreate() to ensure.");
   , data.length));
    --- End diff --
    Isn't this potentially going to break legacy clients depending on how they handle exceptions
thrown from this method?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message