curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] curator pull request: Support EPHEMERAL_SEQUENTIAL nodes for Servi...
Date Mon, 21 Mar 2016 20:44:26 GMT
Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/137#discussion_r56893487
  
    --- Diff: curator-x-discovery-server/src/main/java/org/apache/curator/x/discovery/server/rest/DiscoveryResource.java
---
    @@ -90,7 +90,7 @@ public Response     putService(ServiceInstance<T> instance, @PathParam("name")
S
                 return Response.status(Response.Status.BAD_REQUEST).build();
             }
             
    -        if ( instance.getServiceType() == ServiceType.DYNAMIC )
    +        if ( instance.getServiceType() == ServiceType.DYNAMIC || instance.getServiceType()
== ServiceType.DYNAMIC_SEQUENTIAL )
    --- End diff --
    
    Maybe we can add an `.isDynamic()` method to `ServiceType` and call that instead of checking
against these two specific cases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message