curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Support EPHEMERAL_SEQUENTIAL nodes for Servi...
Date Mon, 21 Mar 2016 04:15:12 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/137#discussion_r56781211
  
    --- Diff: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceDiscoveryImpl.java
---
    @@ -220,7 +220,17 @@ protected void internalRegisterService(ServiceInstance<T> service)
throws Except
             {
                 try
                 {
    -                CreateMode mode = (service.getServiceType() == ServiceType.DYNAMIC) ?
CreateMode.EPHEMERAL : CreateMode.PERSISTENT;
    +            	CreateMode mode;
    +            	switch (service.getServiceType()){
    +            	case DYNAMIC:
    +            		mode =  CreateMode.EPHEMERAL;
    +            		break; 
    +            	case  DYNAMIC_SEQUENTIAL:
    +            		mode =  CreateMode.EPHEMERAL_SEQUENTIAL;
    +            		break; 
    +            	default:
    +            		mode = CreateMode.PERSISTENT;
    --- End diff --
    
    needs a <code>break;</code>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message