Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
MIME-Version: 1.0
In-Reply-To: <1016E5E2-4561-4F71-B630-5A43908C479C@jordanzimmerman.com>
References: 
 <CALuNCpg2=HuwNAisCR7zKOgb7wb4bcDWBi3XaNXicsuNh4UL=w@mail.gmail.com>
	<CDBFDBFE-31EE-4607-AE26-C637D70CC6BA@jordanzimmerman.com>
	<CALuNCpiOFr8aG42CGx7pg5O-DqCyyOftmeo2no6FCnutyMu7hw@mail.gmail.com>
	<CALuNCphJvZpyMxQCLCpmMZ4Ff5KpChaMm-8CQaELT5z+41RCJw@mail.gmail.com>
	<CALuNCph7oA6NfpXhHVYcXu57s6o-F1imngEX651hc=Q+7Gphmg@mail.gmail.com>
	<1016E5E2-4561-4F71-B630-5A43908C479C@jordanzimmerman.com>
Date: Wed, 3 Feb 2016 19:45:20 -0500
Message-ID: 
 <CALuNCpiviQ0E062eWjU8UMMXrvNUgTHczzwSWT5TmFPgKR-PoA@mail.gmail.com>
Subject: Re: Can't merge master into 3.0
From: Scott Blum <dragonsinth@gmail.com>
To: Jordan Zimmerman <jordan@jordanzimmerman.com>
Cc: "dev@curator.apache.org" <dev@curator.apache.org>
Content-Type: multipart/alternative; boundary=001a1142e6f89218d7052ae70ccc

--001a1142e6f89218d7052ae70ccc
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

TestTreeCache.testBasics() fails during teardown on CURATOR-3.0 (4e4072b)

On Wed, Feb 3, 2016 at 7:21 PM, Jordan Zimmerman <jordan@jordanzimmerman.co=
m
> wrote:

> Scott, do you have a small test that shows this error? I=E2=80=99d really=
 like to
> fix it and can=E2=80=99t get a reproducible case.
>
> -Jordan
>
> On Feb 1, 2016, at 3:14 PM, Scott Blum <dragonsinth@gmail.com> wrote:
>
> Alright, I've git bisected it down to a single change that breaks
> TestTreeCache:
>
> WatcherRemovalManager.internalRemove,
>
> private synchronized void internalRemove(WrappedWatcher entry)
> {
>     namespaceWatcherMap.removeWatcher(entry.watcher);
>     entries.remove(entry);
> }
>
> The offending line seems to be the namespaceWatcherMap.removeWatcher.  If
> I comment out that line, TestTreeCache passes.
>
>
> On Mon, Feb 1, 2016 at 3:05 PM, Scott Blum <dragonsinth@gmail.com> wrote:
>
>> I think there may be some general problem, I notice warning messages in
>> the test logs, like:
>>
>> ERROR org.apache.zookeeper.ClientCnxn  Failed to find watcher!
>> [main-SendThread(127.0.0.1:60086)]
>> org.apache.zookeeper.KeeperException$NoWatcherException: KeeperErrorCode
>> =3D No such watcher for /test/one
>> at
>> org.apache.zookeeper.ZooKeeper$ZKWatchManager.containsWatcher(ZooKeeper.=
java:377)
>> at
>> org.apache.zookeeper.ZooKeeper$ZKWatchManager.removeWatcher(ZooKeeper.ja=
va:252)
>> at
>> org.apache.zookeeper.WatchDeregistration.unregister(WatchDeregistration.=
java:58)
>>
>>
>> On Mon, Feb 1, 2016 at 3:04 PM, Scott Blum <dragonsinth@gmail.com> wrote=
:
>>
>>> Actually, it's not a problem with the changes I'm trying to merge in;
>>> TestTreeCache is currently broken on 3.0 branch already.
>>>
>>> Looks like it broke on
>>> revision c6a22ba508f9227fe1c657f93e3cc77d8bc17e3e, which was a merge fr=
om
>>> master into 3.0, with some conflict resolution.
>>>
>>> On Mon, Feb 1, 2016 at 2:46 PM, Jordan Zimmerman <
>>> jordan@jordanzimmerman.com> wrote:
>>>
>>>> I can try to merge when I get a chance. At some point, we should move
>>>> CURATOR-3.0 to master so we don=E2=80=99t have to keep maintaining thi=
s.
>>>>
>>>> -JZ
>>>>
>>>> On Feb 1, 2016, at 2:38 PM, Scott Blum <dragonsinth@gmail.com> wrote:
>>>>
>>>> TestTreeCache fails on 6acf0987125469ecb79ff48ce5e9735a98cd1abb
>>>> <http://git-wip-us.apache.org/repos/asf/curator/commit/6acf0987>, a
>>>> proposed merge of master into 3.0.
>>>>
>>>> It has something to do with the new watcher stuff, but I haven't been
>>>> able to figure out what the problem is, possible because I don't under=
stand
>>>> the new stuff well enough.  Any ideas?
>>>>
>>>>
>>>>
>>>
>>
>
>

--001a1142e6f89218d7052ae70ccc--