curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: Major re-work of Watcher wrappers
Date Fri, 05 Feb 2016 01:49:56 GMT
GitHub user Randgalt opened a pull request:

    https://github.com/apache/curator/pull/131

    Major re-work of Watcher wrappers

    Major re-work of Watcher wrappers. It really isn't necessary to keep a map of watchers.
It was originally done so that watcher identity was maintained, but this can be achieved much
easier using special-purpose hashCode() and equals() on NamespaceWatcher.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/curator better-namspace-watcher

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit ff8a795e61d0d44622bdbaf2144c25c70e31e864
Author: randgalt <randgalt@apache.org>
Date:   2016-02-04T23:57:35Z

    Major re-work of Watcher wrappers. It really isn't necessary to keep a map of watchers.
It was originally done so that watcher identity was maintained, but this can be achieved much
easier using special-purpose hashCode() and equals() on NamespaceWatcher.

commit 3db108102b64255671e472725dc8496a45d8a7e4
Author: randgalt <randgalt@apache.org>
Date:   2016-02-05T01:48:17Z

    The path should be part of NamespaceWatcher's identity. Also, I can simplify WatcherRemovalManager

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message