curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <...@git.apache.org>
Subject [GitHub] curator pull request: Major re-work of Watcher wrappers
Date Mon, 08 Feb 2016 17:30:32 GMT
Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/131#discussion_r52198800
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
    @@ -240,11 +238,7 @@ public void createContainers(String path) throws Exception
         @Override
         public void clearWatcherReferences(Watcher watcher)
         {
    -        NamespaceWatcher namespaceWatcher = namespaceWatcherMap.remove(watcher);
    -        if ( namespaceWatcher != null )
    -        {
    -            namespaceWatcher.close();
    -        }
    --- End diff --
    
    Just a question here.  The super class doc reads `@deprecated As of ZooKeeper 3.5 Curators
recipes will handle removing watcher references when they are no longer used.`
    
    Is this still the most accurate comment?  My (loose) understanding is that even the recipes
themselves don't need to worry about this as the framework will handle it for them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message