curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dragonsinth <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-294: Optimize TreeCache, fix possibl...
Date Mon, 01 Feb 2016 17:23:47 GMT
Github user dragonsinth commented on a diff in the pull request:

    https://github.com/apache/curator/pull/128#discussion_r51449251
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/PathChildrenCache.java
---
    @@ -448,7 +448,10 @@ public boolean clearDataBytes(String fullPath, int ifVersion)
             {
                 if ( (ifVersion < 0) || (ifVersion == data.getStat().getVersion()) )
                 {
    -                data.clearData();
    +                if ( data.getData() != null )
    +                {
    +                    currentData.replace(fullPath, data, new ChildData(data.getPath(),
data.getStat(), null));
    +                }
    --- End diff --
    
    @Randgalt this is the replacement for `clearData()`.  Instead of the ChildData object
being mutable, we just replace the ChildData entirely with a copy that has no data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message