curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-294: Optimize TreeCache, fix possibl...
Date Mon, 01 Feb 2016 17:16:52 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/128#discussion_r51448286
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/ChildData.java
---
    @@ -92,7 +92,7 @@ public int hashCode()
         {
             int result = path != null ? path.hashCode() : 0;
             result = 31 * result + (stat != null ? stat.hashCode() : 0);
    -        result = 31 * result + (data != null ? Arrays.hashCode(data.get()) : 0);
    +        result = 31 * result + Arrays.hashCode(data);
    --- End diff --
    
    data can legally be null. null checks need to be added throughout this class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message