Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: Unit tests failing
From: Jordan Zimmerman <jordan@jordanzimmerman.com>
In-Reply-To: 
 <CANykdua64-gptkH7kVjVL+Kt8E2pAaJ6cQrL+txkHL==vdgijQ@mail.gmail.com>
Date: Thu, 14 Jan 2016 22:44:15 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <BCC149DE-F664-45F7-9FE4-87166809907D@jordanzimmerman.com>
References: 
 <CANykdubwyn8kF=enLut4E5Mb3n3ynJAr8g27xuv92vVto4GRcQ@mail.gmail.com>
 <6CE6DD72-E164-4091-828A-BF9C6BE7E87B@jordanzimmerman.com>
 <CANykdua-Bu_7rf-VLh039V+T+p=gUjFTZRca+FrR6r0V_z8coQ@mail.gmail.com>
 <639E8674-DA58-43CE-BADE-52F9C422A37B@jordanzimmerman.com>
 <CANykduaK1WFsFNO+kds33P5wBifq7cfu_gkDx9Qh3YA==2wPBw@mail.gmail.com>
 <CANykdubdWUKkL0o3TWeAKr7B2NLPgNkd6hG6O+nyD1Stub5esA@mail.gmail.com>
 <28637E69-331B-4811-907B-8F11AE2E1356@jordanzimmerman.com>
 <CANykdua64-gptkH7kVjVL+Kt8E2pAaJ6cQrL+txkHL==vdgijQ@mail.gmail.com>
To: dev@curator.apache.org

Please merge CURATOR-208 into a new test branch along with your =
CURATOR-278 changes and see how it goes. I=E2=80=99ve done multiple full =
test runs now with 100% success.

-Jordan

> On Jan 14, 2016, at 6:49 PM, Cameron McKenzie <mckenzie.cam@gmail.com> =
wrote:
>=20
> I'll have a look at whether it was working pre CURATOR-278. I'm fairly =
sure
> it's related to that fix, and I think that the test case is ok.
>=20
> On Fri, Jan 15, 2016 at 1:20 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>=20
>> OK - I=E2=80=99ll have a look. However, someone submitted that test =
and I don=E2=80=99t
>> know the code at all. So, it may take me some time.
>>=20
>> -JZ
>>=20
>>> On Jan 13, 2016, at 11:19 PM, Cameron McKenzie =
<mckenzie.cam@gmail.com>
>> wrote:
>>>=20
>>> Jordan,
>>> Can you have a look at TestLeaderSelectorEdges:
>>> createProtectedNodeInBackgroundTest? I've had a bit of a look into =
it,
>> and
>>> I'm pretty sure that it's something to do with the changes made for
>>> CURATOR-209. It's failing about 90% of the time for me. Seems like =
under
>>> some conditions a failed create of a sequential ephemeral node does =
not
>> get
>>> cleaned up correctly, but I'm struggling to work out what exactly.
>>> cheers
>>>=20
>>> On Wed, Jan 13, 2016 at 1:22 PM, Cameron McKenzie <
>> mckenzie.cam@gmail.com>
>>> wrote:
>>>=20
>>>> Thanks, just checked on builds.apache.org and the same tests seem =
to be
>>>> failing there also. I'll try and look into it when I get a minute.
>>>> cheers
>>>>=20
>>>> On Wed, Jan 13, 2016 at 8:39 AM, Jordan Zimmerman <
>>>> jordan@jordanzimmerman.com> wrote:
>>>>=20
>>>>> Sorry - I haven=E2=80=99t. I=E2=80=99ll try soon. You can also use =
Apache=E2=80=99s Jenkins.
>>>>>=20
>>>>>> On Jan 12, 2016, at 4:09 PM, Cameron McKenzie =
<mckenzie.cam@gmail.com
>>>=20
>>>>> wrote:
>>>>>>=20
>>>>>> Did you get time to run these unit tests in your environment =
Jordan? I
>>>>> want
>>>>>> to make sure that the unit tests are passing before I merge
>> CURATOR-278.
>>>>>>=20
>>>>>> The tests failing are not related to this JIRA, but still, I =
don't
>> want
>>>>> to
>>>>>> merge with tests failing.
>>>>>> cheers
>>>>>>=20
>>>>>> On Tue, Jan 12, 2016 at 1:44 PM, Jordan Zimmerman <
>>>>>> jordan@jordanzimmerman.com> wrote:
>>>>>>=20
>>>>>>> I haven=E2=80=99t tested in a while. I=E2=80=99ll have a look.
>>>>>>>=20
>>>>>>>> On Jan 11, 2016, at 9:43 PM, Cameron McKenzie <
>> mckenzie.cam@gmail.com
>>>>>>=20
>>>>>>> wrote:
>>>>>>>>=20
>>>>>>>> Guys,
>>>>>>>> Is anyone else having issues with the
>>>>>>>> =
TestResetConnectionWithBackgroundFailure:testConnectionStateListener
>>>>>>> test?
>>>>>>>>=20
>>>>>>>> It is consistently failing for me because the last LOST event =
is not
>>>>>>> being
>>>>>>>> generated. Any ideas?
>>>>>>>>=20
>>>>>>>> I'm also seeing consistent failure of
>>>>>>>>=20
>>>>>>>> TestLeaderSelectorEdges:createProtectedNodeInBackgroundTest
>>>>>>>>=20
>>>>>>>> java.lang.AssertionError: Still 1 znodes under /mylock lock =
expected
>>>>> [0]
>>>>>>>> but found [1]
>>>>>>>>=20
>>>>>>>> cheers
>>>>>>>=20
>>>>>>>=20
>>>>>=20
>>>>>=20
>>>>=20
>>=20
>>=20