Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: TreeCache wasDeleted()
From: Jordan Zimmerman <jordan.zimmerman@elastic.co>
In-Reply-To: 
 <CALuNCpiwanjnbgKwCKWaD6u3EcqKvmu0h_nHFd9gLav2fYOrXg@mail.gmail.com>
Date: Mon, 18 Jan 2016 15:56:15 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <A72098CD-E4E9-474A-9C70-9CBE1FEE6080@elastic.co>
References: <6497B530-CF32-460C-A75F-329E583BA09F@elastic.co>
 <CALuNCpiwanjnbgKwCKWaD6u3EcqKvmu0h_nHFd9gLav2fYOrXg@mail.gmail.com>
To: dev@curator.apache.org

So, this would be right then?

=
client.watches().remove(this).ofType(WatcherType.Any).inBackground().forPa=
th(path);	// NEW


> On Jan 18, 2016, at 3:42 PM, Scott Blum <dragonsinth@gmail.com> wrote:
>=20
> It looks like the history has gotten super gnarly, so it's hard to =
track
> code provenance.  But the call to client.clearWatcherReferences(this) =
has
> always been there.  It's important for long running TreeCaches to be =
able
> to clear dead watchers as they go.
>=20
> On Mon, Jan 18, 2016 at 2:09 PM, Jordan Zimmerman <
> jordan.zimmerman@elastic.co> wrote:
>=20
>> Hi Scott,
>>=20
>> In TreeCache wasDeleted(), there is a call to clear watchers. When =
was
>> this added? I=E2=80=99m trying to merge into CURATOR-3.0 and the new =
behavior would
>> be to remove the watcher via the ZK API. Is this correct or should =
the
>> watcher stay? Please advise. The new code would be:
>>=20
>> stat.getAndSet(null);
>> data.getAndSet(null);
>> =
client.watches().remove(this).ofType(WatcherType.Any).inBackground().forPa=
th(path);
>>   // NEW
>>=20