curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joelittlejohn <...@git.apache.org>
Subject [GitHub] curator pull request: Add note to explain why service providers sh...
Date Tue, 12 Jan 2016 13:25:56 GMT
GitHub user joelittlejohn opened a pull request:

    https://github.com/apache/curator/pull/121

    Add note to explain why service providers should be cached/reused

    Since NamespaceWatchers cannot be removed in Zookeeper 3.4.x, anyone using the service
discovery recipe in Curator 2.x should cache each service provider they create and reuse it
for subsequent calls to that service.
    
    @Randgalt let me know if this doc change is along the lines you were thinking.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joelittlejohn/curator CURATOR-286

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit 0823ce67791ffeb49e2d63a02e467bd3b72cda05
Author: Joe Littlejohn <joelittlejohn@gmail.com>
Date:   2016-01-12T13:23:20Z

    Add note to explain why service providers should be cached/reused
    
    Since NamespaceWatchers cannot be removed in Zookeeper 3.4.x, anyone
    using the service discovery recipe in Curator 2.x should cache each
    service provider they create and reuse it for subsequent calls to that
    service.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message