curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Zimmerman <randg...@apache.org>
Subject Re: TreeCache wasDeleted()
Date Mon, 18 Jan 2016 21:10:38 GMT
FYI - here's the code change. I just pushed it:
https://github.com/apache/curator/blob/CURATOR-3.0/curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/TreeCache.java#L308

On Mon, Jan 18, 2016 at 3:56 PM, Jordan Zimmerman
<jordan.zimmerman@elastic.co> wrote:
> So, this would be right then?
>
> client.watches().remove(this).ofType(WatcherType.Any).inBackground().forPath(path); 
   // NEW
>
>
>> On Jan 18, 2016, at 3:42 PM, Scott Blum <dragonsinth@gmail.com> wrote:
>>
>> It looks like the history has gotten super gnarly, so it's hard to track
>> code provenance.  But the call to client.clearWatcherReferences(this) has
>> always been there.  It's important for long running TreeCaches to be able
>> to clear dead watchers as they go.
>>
>> On Mon, Jan 18, 2016 at 2:09 PM, Jordan Zimmerman <
>> jordan.zimmerman@elastic.co> wrote:
>>
>>> Hi Scott,
>>>
>>> In TreeCache wasDeleted(), there is a call to clear watchers. When was
>>> this added? I’m trying to merge into CURATOR-3.0 and the new behavior would
>>> be to remove the watcher via the ZK API. Is this correct or should the
>>> watcher stay? Please advise. The new code would be:
>>>
>>> stat.getAndSet(null);
>>> data.getAndSet(null);
>>> client.watches().remove(this).ofType(WatcherType.Any).inBackground().forPath(path);
>>>   // NEW
>>>
>

Mime
View raw message