curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Zimmerman <jor...@jordanzimmerman.com>
Subject Re: Please review https://github.com/apache/curator/pull/125
Date Fri, 15 Jan 2016 03:45:04 GMT
FYI - testing found some issues with the blunt-force approach. I’ve just pushed some changes
to mitigate this. There are a few loops that should, rightfully,  not reset the thread interrupt
state.

-Jordan

> On Jan 13, 2016, at 3:52 PM, John Vines <vines@apache.org> wrote:
> 
> It's not an explicit worry, just a general 'tread lightly' feeling. If
> testing shows that it's not a problem (which I would expect to be the case)
> then it's probably fine.
> 
> On Wed, Jan 13, 2016 at 3:37 PM Jordan Zimmerman <jordan@jordanzimmerman.com>
> wrote:
> 
>> 
>>> Only concern I have is around behavior of curator
>>> owned/managed threads (caches and the like).
>> 
>> What’s the worry? Can you explain?
>> 
>> -Jordan


Mime
View raw message