curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-208] General fix for catch-alls thr...
Date Sun, 17 Jan 2016 22:07:10 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/125#discussion_r49953348
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
    @@ -257,8 +258,7 @@ public void stateChanged(CuratorFramework client, ConnectionState
newState)
     
                 client.start();
     
    -            executorService = Executors.newFixedThreadPool(2, threadFactory);  // 1 for
listeners, 1 for background ops
    -
    +            executorService = Executors.newSingleThreadScheduledExecutor(threadFactory);
    --- End diff --
    
    The comment was wrong. This must have changed at some point. I noticed only 1 was being
used and corrected it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message