curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: Support delete().quietly() and create().orSe...
Date Sun, 04 Oct 2015 22:34:02 GMT
Github user cammckenzie commented on the pull request:

    https://github.com/apache/curator/pull/111#issuecomment-145394959
  
    Looks ok to me, though when I ran the tests an unrelated test is failling.
    
    BasicTests:testFactory is failing.
    
    This appears to be because the constructor for CuratorZookeeperClient does not use the
ZookeeperFactory reference passed to it, and just instantiates a DefaultZookeeperFactory.
I presume this change was made by some other fix? If I change the constructor to use the passed
in factory, the test passes ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message