Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
Date: Thu, 3 Sep 2015 20:43:45 +0000 (UTC)
From: "Jordan Zimmerman (JIRA)" <jira@apache.org>
To: dev@curator.apache.org
Message-ID: <JIRA.12860880.1441076587000.250950.1441313025674@Atlassian.JIRA>
In-Reply-To: <JIRA.12860880.1441076587000@Atlassian.JIRA>
References: <JIRA.12860880.1441076587000@Atlassian.JIRA>
 <JIRA.12860880.1441076587753@arcas>
Subject: [jira] [Commented] (CURATOR-257) Thread.sleep in
 TestingZooKeeperMain.blockUntilStarted is costly for unit tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CURATOR-257?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D147=
29746#comment-14729746 ]=20

Jordan Zimmerman commented on CURATOR-257:
------------------------------------------

This could be an error in the test. I'll have a look when I get a chance.

> Thread.sleep in TestingZooKeeperMain.blockUntilStarted is costly for unit=
 tests
> -------------------------------------------------------------------------=
------
>
>                 Key: CURATOR-257
>                 URL: https://issues.apache.org/jira/browse/CURATOR-257
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Martin Serrano
>            Priority: Minor
>
> The {{TestingZooKeeperMain.blockUntilStarted()}} contains a {{Thread.slee=
p(1000)}} call.  In a large battery of unit level tests (which are otherwis=
e quick and depend on curator service discovery) this time adds up.
> Recent communication from JZ regarding the code:
> {quote}
> As I recall, it takes some time for the server to start up and this was a=
 hack to make sure it=E2=80=99s ready.  However, I no longer remember the d=
etails. Do tests work with the timeout removed?
> {quote}
> We are in the midst of running our battery of tests to see if removal of =
this sleep call causes any issues.   Our set of tests starts and stops the =
testing server a few hundred times within the same process, so I think it w=
ill show any such issues within a few runs.  If no issues appear (and the c=
urator tests pass of course) I will post a pull request. =20
> A sleep of this sort is unreliable to ensure startup anyway.  While it ma=
y be very unlikely for the server not to be up after 1 second, I've found w=
ith similar approaches that these types of solutions will still fail once i=
t a while, leading to odd and hard to reproduce test failures.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)