curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-265) Dynamic Reconfig APIs needs some work and more accurate testing
Date Sat, 26 Sep 2015 02:52:04 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909020#comment-14909020
] 

ASF GitHub Bot commented on CURATOR-265:
----------------------------------------

GitHub user Randgalt opened a pull request:

    https://github.com/apache/curator/pull/107

    [CURATOR-265] Dynamic Reconfig APIs needs some work

    * Completely re-wrote the tests
    * The APIs weren't correct for all permutations
    * adding() API was not correct. In ZK, it's called "newMembers" and is mutually exclusive
with join/leave

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/curator CURATOR-265

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
    
----
commit 034e910a907fa89e1c0cd3373fa3bf8ee7759ae6
Author: Ioannis Canellos <iocanel@gmail.com>
Date:   2014-11-06T14:53:09Z

    Upgrade to ZooKeeper 3.5.0-alpha.

commit d4883a845a3778bcad4a776bb18b146f733d8885
Author: Ioannis Canellos <iocanel@gmail.com>
Date:   2014-11-06T15:30:29Z

    Update project version to 3.0.0-SNAPSHOT.

commit 9ff9ccd23c8d033b2e7d72b83a0183d05f5dd685
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2014-12-01T22:16:40Z

    CURATOR-161 - Initial cut of remove watches functionality. This provides
    the ability to remove watches, but does not yet provide a framework for
    observers being notified when a watch has been removed.

commit b2b9af31c181d7e4f790dbfd9f8850a7b948822d
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2014-12-01T22:56:02Z

    CURATOR-161 - Updates to unit tests.

commit a83090bea7cdd69aa094ddaa9d4a70f401c28861
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-08T04:05:18Z

    CURATOR-161 - Updates to naming based on review. Added unit test for
    local() case, which has still not been resolved. Need to make changes to
    the framework to allow some ZK calls (local watch removal in this case) to
    occur even if no ZK connection is available.

commit 4c2ba3744d90f2af12d815e8aa0747fd0d1a1c67
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-10T23:19:45Z

    CURATOR-161 - Added support for quietly() call that will suppress
    NoWatcherException exceptions.

commit 198ba684ff8bb47e10e40dd46c6e97023b7a365f
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-11T02:38:18Z

    CURATOR-161 - Changed local() call to be called locally()

commit 389e0b0d29899bd35ebd4d7c81302d3d8ee53889
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-11T03:14:40Z

    CURATOR-161 - Modified to make the watcher type optional, defaulting to
    'All'.

commit 58fcc548f87e3c787f82d48931e2e9992f6c3366
Author: randgalt <randgalt@apache.org>
Date:   2015-05-11T20:29:09Z

    first pass at implementation and a simple test

commit d3672a5acbd2bdf0f8caa9b7c8ea07e9d4e4dd2a
Author: randgalt <randgalt@apache.org>
Date:   2015-05-11T21:19:45Z

    wip

commit 04caf36cd4ee76b358c7866da18c858b5608ebca
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-11T21:46:43Z

    CURATOR-161 - Some progress in getting locally() to work. Working now for
    the foreground case, but still not working for the background case because
    it tries to guarantee a connection before the command is executed.

commit 49b2fd3a8313cd05292e2ca8edb4b14b08f0de55
Author: randgalt <randgalt@apache.org>
Date:   2015-05-11T23:04:01Z

    more tests, refinements

commit ff8eb4b2ec7c99258e62416453bef649fdc6220e
Author: randgalt <randgalt@apache.org>
Date:   2015-05-12T01:48:16Z

    more tests

commit 5030c198456150a82bf2a2a2e5aea75b65b2efc8
Author: randgalt <randgalt@apache.org>
Date:   2015-05-12T13:53:24Z

    wip

commit 22d034af90987940420649c5f320e8dc09910c8a
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-12T23:28:45Z

    CURATOR-161 - Added support for guaranteed removal of watches. This
    includes refactoring the FailedDeleteManager code into a
    FailedOperationManager to allow subclassing.

commit ba4da2c3c7048ea249f18e7b4c815db76f0b1ad0
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-13T23:19:09Z

    CURATOR-161 - Modified the background processing framework to allow
    operations to request that a live connection is not necessary to execute
    (this is needed to run the remove watches with 'local' set to true.
    Cleaned up some unit tests.

commit a47c03671452a20e70deb2b8668d70bd92d78ce7
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-13T23:33:22Z

    CURATOR-161 - Fixed up some potential race conditions with unit tests.

commit 79d152ca42b0a34826369c5620ce7807c668ad63
Author: randgalt <randgalt@apache.org>
Date:   2015-05-19T23:37:08Z

    doc

commit 43afca7b902bf3d52c33c23924be4ca37c4df23f
Author: randgalt <randgalt@apache.org>
Date:   2015-05-19T23:38:37Z

    doc

commit fb274b1c8d56eeae97c50966ba69e6b98fd71274
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T00:52:58Z

    Merge branch 'CURATOR-161' into CURATOR-217

commit 115611eca927b6e8f91a0f27af46a888eac6b008
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T00:56:35Z

    Do watcher removal guaranteed in background

commit 4f21e318f796cec4b32cafe14e0e2bf240817114
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-20T01:57:10Z

    CURATOR-161 - Updates after review.

commit 6612c91e7f6aa50ce961e0bfcc9fb4c3134e0a39
Author: Cameron McKenzie <cameron@unico.com.au>
Date:   2015-05-20T02:03:17Z

    CURATOR-161 - Added @VisibleForTesting annotation to debugListener

commit 4ad09e7d1d71acebba97bb5594205d96f76eba3c
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T02:38:24Z

    make test more rational by using a latch

commit ff2ed8490660a3ea8caa046ecc5f80664cb0d8bd
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T02:40:46Z

    make test more rational by using a latch

commit eba6ce8f9ae772d0a30ced495b1b9130dec0ad40
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T02:42:23Z

    Merge branch 'CURATOR-161' into CURATOR-217
    
    Conflicts:
    	curator-framework/src/main/java/org/apache/curator/framework/api/BackgroundPathableQuietly.java

commit a95d52e53ef0fc63468eb1fc257869c82bd3dc4e
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T03:01:26Z

    Use WatcherRemoveCuratorFramework in a few more places

commit 2c921d62fc2894f136d088d93870ac8c9b026dcb
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T03:33:40Z

    More uses of WatcherRemoveCuratorFramework, more tests, etc.

commit f0a09db4423f06455ed93c20778c65aaf7e8b06e
Author: randgalt <randgalt@apache.org>
Date:   2015-05-20T05:42:14Z

    Added WatcherRemoveCuratorFramework to locks and updated tests to check for cleanliness

commit 227aaf3f56dd2e587977f97d10b9b8b20525830a
Author: Ioannis Canellos <iocanel@gmail.com>
Date:   2014-11-06T14:53:09Z

    Upgrade to ZooKeeper 3.5.0-alpha.

----


> Dynamic Reconfig APIs needs some work and more accurate testing
> ---------------------------------------------------------------
>
>                 Key: CURATOR-265
>                 URL: https://issues.apache.org/jira/browse/CURATOR-265
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 3.0.0
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>             Fix For: 3.0.0
>
>
> The new dynamic reconfig APIs don't have all permutations and the tests are flakey.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message