Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 414421898D for ; Fri, 7 Aug 2015 19:07:46 +0000 (UTC) Received: (qmail 55119 invoked by uid 500); 7 Aug 2015 19:07:46 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 55069 invoked by uid 500); 7 Aug 2015 19:07:46 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 54962 invoked by uid 99); 7 Aug 2015 19:07:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Aug 2015 19:07:46 +0000 Date: Fri, 7 Aug 2015 19:07:45 +0000 (UTC) From: "Mike Drob (JIRA)" To: dev@curator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CURATOR-129) Two of PathChildrenCache's constructors need better doc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CURATOR-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662282#comment-14662282 ] Mike Drob commented on CURATOR-129: ----------------------------------- I just pushed this change. Can somebody look and verify that I handled things the way that we're used to? Created a branch, pushed it to the git repository with the fix. Merged it into master, added a line about closing the pull request to the commit message, and then pushed that. Looks like it ended up being a fast-forward instead of giving me a merge commit. Do we have a preference on that? I couldn't find anything on the wiki pages indicating one way or the other. > Two of PathChildrenCache's constructors need better doc > ------------------------------------------------------- > > Key: CURATOR-129 > URL: https://issues.apache.org/jira/browse/CURATOR-129 > Project: Apache Curator > Issue Type: Improvement > Components: Documentation, Recipes > Affects Versions: 2.6.0 > Reporter: Jordan Zimmerman > > The two constructors for PathChildrenCache that take executors as arguments need to document that the executors must be single threaded. If a pool executor is passed in, PathChildrenCache will not work correctly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)