Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA4ED18A60 for ; Tue, 18 Aug 2015 03:27:52 +0000 (UTC) Received: (qmail 91149 invoked by uid 500); 18 Aug 2015 03:27:47 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 91101 invoked by uid 500); 18 Aug 2015 03:27:47 -0000 Mailing-List: contact dev-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list dev@curator.apache.org Received: (qmail 91089 invoked by uid 99); 18 Aug 2015 03:27:47 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Aug 2015 03:27:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E0D60C1347 for ; Tue, 18 Aug 2015 03:27:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.899 X-Spam-Level: *** X-Spam-Status: No, score=3.899 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id U7d1xhLL4HZ9 for ; Tue, 18 Aug 2015 03:27:39 +0000 (UTC) Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id AD1E5207D6 for ; Tue, 18 Aug 2015 03:27:38 +0000 (UTC) Received: by iodv127 with SMTP id v127so158859272iod.3 for ; Mon, 17 Aug 2015 20:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Mxncv8kKFdZzBnKVngivUJ4loFxate/2owgCPdsLUg8=; b=ZStSCyoBAxEuUPYyJk/VxKyeO0DLC0/ono7dmFUW0Snq2gEWX4w5r8996Ey5va7bmb 094Ted/+bHO0bEbAZX2XMB/5wxsr1g8gGprNaQ7DfSBJvamZa8zsT1S2IVlFCW2PjFze 6xWWHXbJcbFNrFR5LsuEEJv4bG+CKXnhbZXTJKyymASh+Agp/1SO51OGgvmiaXsJa8VT lSq8FZzjoHfNeunh8ScBziK63e3TrP7UsOOTwywKGixaUUoY2a5MRjkxYyO7W8F7cJsM t02PAXcLi8aAbkYmnkkH0RJRSOIJaZ/RTmBCL+b42LCE4ryQGhwRpoftIzlm06sgYuda sOCw== MIME-Version: 1.0 X-Received: by 10.107.130.156 with SMTP id m28mr5513265ioi.56.1439868457721; Mon, 17 Aug 2015 20:27:37 -0700 (PDT) Received: by 10.64.230.176 with HTTP; Mon, 17 Aug 2015 20:27:37 -0700 (PDT) In-Reply-To: References: <6A96E809-8DC6-4BBF-B40D-B542B6E4D888@jordanzimmerman.com> <90EAFA8B-696D-47C3-ADD6-E15589D4C67F@jordanzimmerman.com> Date: Mon, 17 Aug 2015 23:27:37 -0400 Message-ID: Subject: Re: Next Steps From: Scott Blum To: "dev@curator.apache.org" Cc: Cameron McKenzie Content-Type: multipart/alternative; boundary=001a113ecfdaf22346051d8d7fde --001a113ecfdaf22346051d8d7fde Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I think just confirm that ZooDefs.CONFIG_NODE is the correct watcher path for getConfig()? On Mon, Aug 17, 2015 at 11:19 PM, Jordan Zimmerman < jordan@jordanzimmerman.com> wrote: > Sorry - it=E2=80=99s hard to follow this thread. What do I need to do? > > -Jordan > > > > On August 17, 2015 at 6:18:21 PM, Cameron McKenzie (mckenzie.cam@gmail.co= m) > wrote: > > Thanks Scott, > I've just merged CURATOR-217 into master and have one small issue. > > Jordan, with the changes you made with to the Watching.java class, the > getWatcher() call now takes a CuratorFramework reference and a path > reference. > > The GetConfigBuilderImpl breaks when merging because it's using the old > getWatcher() call that doesn't exist any more. This isn't an issue to fix= , > but I'm just wondering what path reference should be used for the > configuration case, as it's a different sort of watch. It's just passed t= o > the getConfig() call on the ZooKeeper class. It seems that I can't just > pass in a null path as this gets validated. Suggestions? > > cheers > > > On Tue, Aug 18, 2015 at 3:30 AM, Jordan Zimmerman < > jordan@jordanzimmerman.com> wrote: > > > Great work. Thank you. > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > Jordan Zimmerman > > > > > On Aug 17, 2015, at 12:10 PM, Scott Blum > wrote: > > > > > > This is now done, sorry for the delay. Let me describe the current > state > > > of the world: > > > > > > CURATOR-215-original, CURATOR-160-original, CURATOR-3.0-old, > > > CURATOR-3.0-temp - these are the old versions of all the branches, we > > > should consider pruning them at some point. > > > > > > CURATOR-215, CURATOR-160, CURATOR-3.0 - these are fixed/rebased > versions > > of > > > the branches we should stick with. > > > > > > *ALL MASTER COMMITS ARE NOW MERGED INTO CURATOR-3.0.* There is nothin= g > > > that has been committed to master that isn't in 3.0 now. > > > > > > Procedures going forward: > > > > > > - If you're working on stuff for 2.8 / 2.9, branch from master and > > > merge/commit to master. > > > > > > - If you're working on stuff for 3.0, branch from CURATOR-3.0 and > > > merge/commit to CURATOR-3.0. > > > > > > - Periodically, we'll want to get master changes into 3.0. To do this= , > > *check > > > out CURATOR-3.0*, and merge master into that, then push the result > after > > > fixing conflicts (which should be small / non-existent). *Don't do it > > the > > > other way, don't check out master and merge 3.0 into it.* > > > > > > For discussion: there is a *3.0-rejects* branch. One of the commits > > there > > > is and added System.out.println that I think we don't want. The other > > one > > > is the work to migrate to fasterxml Jackson. I think we actually want > > this > > > commit on 3.0. Please take a look and let me know, if we want this > > commit, > > > we should cherry-pick it onto 3.0. I'm happy to do that. > > > > > > Everything I did should be reversible, so let me know if I screwed > > anything > > > up! > > > > > > --Scott > > > --001a113ecfdaf22346051d8d7fde--