Mailing-List: contact dev-help@curator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.apache.org
From: cammckenzie <git@git.apache.org>
To: dev@curator.apache.org
Reply-To: dev@curator.apache.org
References: <git-pr-96-curator@git.apache.org>
In-Reply-To: <git-pr-96-curator@git.apache.org>
Subject: [GitHub] curator pull request: CURATOR-214 - Implemented new ZK API
 to allo...
Content-Type: text/plain
Message-Id: <20150824213111.5A6ADE10B1@git1-us-west.apache.org>
Date: Mon, 24 Aug 2015 21:31:11 +0000 (UTC)

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/96#discussion_r37807339
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java ---
    @@ -520,12 +539,127 @@ public void processResult(int rc, String path, Object ctx, String name)
                             }
                             else
                             {
    -                            sendBackgroundResponse(rc, path, ctx, name, operationAndData);
    +                            sendBackgroundResponse(rc, path, ctx, name, null, operationAndData);
                             }
                         }
                     },
                     backgrounding.getContext()
                 );
    +        }
    +        else
    +        {
    +            client.getZooKeeper().create
    +            (
    +                operationAndData.getData().getPath(),
    +                operationAndData.getData().getData(),
    +                acling.getAclList(operationAndData.getData().getPath()),
    +                createMode,
    +                new AsyncCallback.Create2Callback() {
    +                    
    +                    @Override
    +                    public void processResult(int rc, String path, Object ctx, String name, Stat stat) {
    +                        trace.commit();
    +                        
    +                        //Need to manually populate the provided stat here.
    +                        storingStat.setAversion(stat.getAversion());
    --- End diff --
    
    Yeah, this is the only place that it's done which is why I left it inline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---