curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-253) Use new injectSessionExpiration() in the test module
Date Mon, 31 Aug 2015 23:41:45 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724402#comment-14724402
] 

ASF GitHub Bot commented on CURATOR-253:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/100#discussion_r38372819
  
    --- Diff: curator-recipes/src/test/java/org/apache/curator/framework/recipes/cache/TestTreeCache.java
---
    @@ -377,7 +377,6 @@ public void testKilledSession() throws Exception
             assertEvent(TreeCacheEvent.Type.NODE_ADDED, "/test/me");
     
             KillSession.kill(client.getZookeeperClient().getZooKeeper(), server.getConnectString());
    -        assertEvent(TreeCacheEvent.Type.CONNECTION_SUSPENDED);
    --- End diff --
    
    Why does the CONNECTION_SUSPENDED event no longer occur? Is this because of the new lifecycle
stuff for session loss?


> Use new injectSessionExpiration() in the test module
> ----------------------------------------------------
>
>                 Key: CURATOR-253
>                 URL: https://issues.apache.org/jira/browse/CURATOR-253
>             Project: Apache Curator
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>             Fix For: 3.0.0
>
>
> ZK 3.5.0 adds the Testable interface and the injectSessionExpiration() method. Curator's
KillSession utils should use this instead of what's currently done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message