curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-233) Bug in double barrier
Date Mon, 24 Aug 2015 21:26:45 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710088#comment-14710088
] 

ASF GitHub Bot commented on CURATOR-233:
----------------------------------------

GitHub user madrob opened a pull request:

    https://github.com/apache/curator/pull/99

    CURATOR-233 Fix DistributedDoubleBarrier::leave

    DDB::leave would not respect the wait time parameters correctly, and
    would sometimes return true, even though not all clients had left the
    barrier.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madrob/curator CURATOR-233

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit 699cefd8e0a26a298774a2688e16f5ec54599408
Author: Mike Drob <mdrob@apache.org>
Date:   2015-08-24T14:27:03Z

    CURATOR-233 Fix DistributedDoubleBarrier::leave
    
    DDB::leave would not respect the wait time parameters correctly, and
    would sometimes return true, even though not all clients had left the
    barrier.

----


> Bug in double barrier
> ---------------------
>
>                 Key: CURATOR-233
>                 URL: https://issues.apache.org/jira/browse/CURATOR-233
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.8.0
>            Reporter: J D
>            Assignee: Mike Drob
>             Fix For: awaiting-response
>
>         Attachments: DoubleBarrierClient.java, DoubleBarrierTester.java
>
>
> Hi,
> I think I discovered a bug in the internalLeave method of the double barrier implementation.
> When a client is told to leave the barrier after maxWait it does not do so. A flag is
set but the client does not leave the barrier, instead it keeps iterating through the control
loop and drives CPU usage to 100%.
> I have attached an example.
> Best regards
> Lianro



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message