curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CURATOR-214) Support new create() APIs
Date Mon, 24 Aug 2015 21:31:45 GMT

    [ https://issues.apache.org/jira/browse/CURATOR-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710096#comment-14710096
] 

ASF GitHub Bot commented on CURATOR-214:
----------------------------------------

Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/96#discussion_r37807339
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
---
    @@ -520,12 +539,127 @@ public void processResult(int rc, String path, Object ctx, String
name)
                             }
                             else
                             {
    -                            sendBackgroundResponse(rc, path, ctx, name, operationAndData);
    +                            sendBackgroundResponse(rc, path, ctx, name, null, operationAndData);
                             }
                         }
                     },
                     backgrounding.getContext()
                 );
    +        }
    +        else
    +        {
    +            client.getZooKeeper().create
    +            (
    +                operationAndData.getData().getPath(),
    +                operationAndData.getData().getData(),
    +                acling.getAclList(operationAndData.getData().getPath()),
    +                createMode,
    +                new AsyncCallback.Create2Callback() {
    +                    
    +                    @Override
    +                    public void processResult(int rc, String path, Object ctx, String
name, Stat stat) {
    +                        trace.commit();
    +                        
    +                        //Need to manually populate the provided stat here.
    +                        storingStat.setAversion(stat.getAversion());
    --- End diff --
    
    Yeah, this is the only place that it's done which is why I left it inline.


> Support new create() APIs
> -------------------------
>
>                 Key: CURATOR-214
>                 URL: https://issues.apache.org/jira/browse/CURATOR-214
>             Project: Apache Curator
>          Issue Type: Sub-task
>          Components: Client, Framework
>            Reporter: Jordan Zimmerman
>            Assignee: Cameron McKenzie
>             Fix For: 3.0.0
>
>
> ZooKeeper 3.5 adds new versions of create() that return the Stat object of the newly
created ZNode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message