curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-253] Use new injectSessionExpiratio...
Date Fri, 28 Aug 2015 18:50:45 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/100#discussion_r38231696
  
    --- Diff: curator-test/src/main/java/org/apache/curator/test/KillSession.java ---
    @@ -18,24 +18,12 @@
      */
     package org.apache.curator.test;
     
    -import org.apache.zookeeper.WatchedEvent;
    -import org.apache.zookeeper.Watcher;
     import org.apache.zookeeper.ZooKeeper;
    -import java.util.concurrent.CountDownLatch;
    -import java.util.concurrent.TimeUnit;
     
     /**
      * <p>
    - *     Utility to simulate a ZK session dying. See: <a href="http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A4">ZooKeeper
FAQ</a>
    + *     Utility to simulate a ZK session dying.
      * </p>
    - *
    - * <blockquote>
    - *     In the case of testing we want to cause a problem, so to explicitly expire a session
an
    - *     application connects to ZooKeeper, saves the session id and password, creates
another
    - *     ZooKeeper handle with that id and password, and then closes the new handle. Since
both
    - *     handles reference the same session, the close on second handle will invalidate
the session
    - *     causing a SESSION_EXPIRED on the first handle.
    - * </blockquote>
      */
     public class KillSession
    --- End diff --
    
    Yeah, probably a good thing. I'll add it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message