curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <>
Subject [GitHub] curator pull request: [CURATOR-253] Use new injectSessionExpiratio...
Date Fri, 28 Aug 2015 18:46:21 GMT
Github user madrob commented on a diff in the pull request:
    --- Diff: curator-test/src/main/java/org/apache/curator/test/ ---
    @@ -18,24 +18,12 @@
     package org.apache.curator.test;
    -import org.apache.zookeeper.WatchedEvent;
    -import org.apache.zookeeper.Watcher;
     import org.apache.zookeeper.ZooKeeper;
    -import java.util.concurrent.CountDownLatch;
    -import java.util.concurrent.TimeUnit;
      * <p>
    - *     Utility to simulate a ZK session dying. See: <a href="">ZooKeeper
    + *     Utility to simulate a ZK session dying.
      * </p>
    - *
    - * <blockquote>
    - *     In the case of testing we want to cause a problem, so to explicitly expire a session
    - *     application connects to ZooKeeper, saves the session id and password, creates
    - *     ZooKeeper handle with that id and password, and then closes the new handle. Since
    - *     handles reference the same session, the close on second handle will invalidate
the session
    - *     causing a SESSION_EXPIRED on the first handle.
    - * </blockquote>
     public class KillSession
    --- End diff --
    New method suggestion: KillSession::kill(CuratorFramework) and that can extract the zookeeper
bits on it's own. More robust for future improvement, maybe?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message