curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-253] Use new injectSessionExpiratio...
Date Fri, 28 Aug 2015 18:45:03 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/100#discussion_r38231138
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentEphemeralNode.java
---
    @@ -111,11 +112,26 @@ public void stateChanged(CuratorFramework client, ConnectionState
newState)
             {
                 if ( newState == ConnectionState.RECONNECTED )
                 {
    +                if ( debugReconnectLatch != null )
    +                {
    +                    try
    +                    {
    +                        debugReconnectLatch.await();
    +                    }
    +                    catch ( InterruptedException e )
    +                    {
    +                        Thread.currentThread().interrupt();
    +                        e.printStackTrace();
    +                    }
    +                }
                     createNode();
                 }
             }
         };
     
    +    @VisibleForTesting
    +    volatile CountDownLatch debugReconnectLatch = null;
    --- End diff --
    
    Can't predict what thread it will come from. In the current use case it doesn't need to
be, but who knows in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message