curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] curator pull request: [CURATOR-253] Use new injectSessionExpiratio...
Date Fri, 28 Aug 2015 18:44:54 GMT
Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/100#discussion_r38231122
  
    --- Diff: curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentEphemeralNode.java
---
    @@ -634,11 +640,6 @@ private CuratorFramework newCurator() throws IOException
             return client;
         }
     
    -    public void killSession(CuratorFramework curator) throws Exception
    -    {
    -        KillSession.kill(curator.getZookeeperClient().getZooKeeper(), curator.getZookeeperClient().getCurrentConnectionString());
    --- End diff --
    
    Why not leave the method and have it do the new thing instead of repeating the same snippet
in a bunch of places?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message