curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randgalt <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-214 - Implemented new ZK API to allo...
Date Mon, 24 Aug 2015 14:03:04 GMT
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/96#discussion_r37753815
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
---
    @@ -520,12 +539,127 @@ public void processResult(int rc, String path, Object ctx, String
name)
                             }
                             else
                             {
    -                            sendBackgroundResponse(rc, path, ctx, name, operationAndData);
    +                            sendBackgroundResponse(rc, path, ctx, name, null, operationAndData);
                             }
                         }
                     },
                     backgrounding.getContext()
                 );
    +        }
    +        else
    +        {
    +            client.getZooKeeper().create
    +            (
    +                operationAndData.getData().getPath(),
    +                operationAndData.getData().getData(),
    +                acling.getAclList(operationAndData.getData().getPath()),
    +                createMode,
    +                new AsyncCallback.Create2Callback() {
    +                    
    +                    @Override
    +                    public void processResult(int rc, String path, Object ctx, String
name, Stat stat) {
    +                        trace.commit();
    +                        
    +                        //Need to manually populate the provided stat here.
    +                        storingStat.setAversion(stat.getAversion());
    --- End diff --
    
    is this the only place this is done? Seems like a candidate for a utility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message