curator-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cammckenzie <...@git.apache.org>
Subject [GitHub] curator pull request: CURATOR-241: Write updated data on reconnect
Date Sun, 02 Aug 2015 23:52:24 GMT
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/95#discussion_r36049904
  
    --- Diff: curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentEphemeralNode.java
---
    @@ -338,10 +338,14 @@ public void setData(byte[] data) throws Exception
             this.data.set(Arrays.copyOf(data, data.length));
             if ( isActive() )
             {
    -            client.setData().inBackground().forPath(getActualPath(), this.data.get());
    +            client.setData().inBackground().forPath(getActualPath(), getData());
             }
         }
     
    +    byte[] getData() {
    --- End diff --
    
    I'd mark it as private for now and it can be exposed later if needed. If it were to be
for testing we mark these as @VisibleForTesting to be explicit as to why it's package protected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message